Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema Creation should Reject SignatureRequired for OnChain and IPFS Payload Locations #1874

Open
wilwade opened this issue Feb 13, 2024 · 4 comments
Labels
bug Something isn't working tech-debt

Comments

@wilwade
Copy link
Collaborator

wilwade commented Feb 13, 2024

Currently it is possible to create a schema with the setting SignatureRequired when also using the PayloadLocation of OnChain or IPFS.

Expected: Schema creation and proposal for creation should reject a schema setting that does not apply to the selected PayloadLocation

As a developer creating a schema (or someone reading a schema), I want to make sure that I do not incorrectly think that the SignatureRequired will do something for Message Storage based schemas, when it does not.

@wilwade wilwade added bug Something isn't working tech-debt labels Feb 13, 2024
@JoeCap08055
Copy link
Collaborator

Would there be any benefit to adding support for SignatureRequired to other pallets besides StatefulStorage?

@wilwade
Copy link
Collaborator Author

wilwade commented Feb 13, 2024

Would there be any benefit to adding support for SignatureRequired to other pallets besides StatefulStorage?

IPFS doesn't have a delegation option, as it assumes the off-chain data handles any delegation interaction.

I think there might be for OnChain, but no clear use case at this point in time.

@JoeCap08055
Copy link
Collaborator

I also think that for schemas with SignatureRequired, we should explicitly reject any delegation requests for that schema.

@wilwade
Copy link
Collaborator Author

wilwade commented Feb 14, 2024

I also think that for schemas with SignatureRequired, we should explicitly reject any delegation requests for that schema.

Hmm... That sounds good, but it requires a load of a lot of data when doing a delegation to check for that flag on schemas. Open to ideas of how to do it for opening a separate issue however.

@wilwade wilwade added this to the 2024 Q2 Tech Debt milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tech-debt
Projects
None yet
Development

No branches or pull requests

2 participants