Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check maximum weight of on_initialize when starting a new era. #1949

Closed
1 task
shannonwells opened this issue Apr 23, 2024 · 0 comments · Fixed by #1966
Closed
1 task

Check maximum weight of on_initialize when starting a new era. #1949

shannonwells opened this issue Apr 23, 2024 · 0 comments · Fixed by #1966
Assignees
@shannonwells
Labels
Provider Boosting
Milestone
Boosting: Non-Eco...

Comments

@shannonwells
Copy link
Collaborator

shannonwells commented Apr 23, 2024 •
edited

We need to get a maximum weight for start_new_era_if_needed so we know whether it's possible to overflow a block on a new reward era. I don't think it's going to be problem but we should have the data.

Acceptance Criterion

  • Update test/benchmark for the entire on_initialize weight when starting a new era.
@shannonwells shannonwells mentioned this issue Apr 23, 2024
Merged
1 task
@shannonwells shannonwells self-assigned this May 8, 2024
@shannonwells shannonwells mentioned this issue May 9, 2024
Merged
2 tasks
shannonwells added a commit that referenced this issue May 13, 2024
@shannonwells
Chores/update capacity benchmarks #1949 (#1966)
f8ada08 
# Goal
The goal of this PR is to update the benchmark for `on_initialize` to include the weight when a new RewardEra must be created.

Closes #1949
shannonwells added a commit that referenced this issue May 14, 2024
@shannonwells
Chores/update capacity benchmarks #1949 (#1966)
03d6d7a 
# Goal
The goal of this PR is to update the benchmark for `on_initialize` to include the weight when a new RewardEra must be created.

Closes #1949
@p5150j p5150j closed this as completed May 15, 2024
shannonwells added a commit that referenced this issue May 21, 2024
@shannonwells
Chores/update capacity benchmarks #1949 (#1966)
5a0ebce 
# Goal
The goal of this PR is to update the benchmark for `on_initialize` to include the weight when a new RewardEra must be created.

Closes #1949
shannonwells added a commit that referenced this issue May 22, 2024
@shannonwells
Chores/update capacity benchmarks #1949 (#1966)
dee3077 
The goal of this PR is to update the benchmark for `on_initialize` to include the weight when a new RewardEra must be created.

Closes #1949
shannonwells added a commit that referenced this issue Jun 12, 2024
@shannonwells
Chores/update capacity benchmarks #1949 (#1966)
a54e97c 
The goal of this PR is to update the benchmark for `on_initialize` to include the weight when a new RewardEra must be created.

Closes #1949
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shannonwells shannonwells

Labels
Provider Boosting
Projects
None yet
Milestone
Boosting: Non-Economic Runtime Code
Development

Successfully merging a pull request may close this issue.

Chores/update capacity benchmarks #1949 frequency-chain/frequency
2 participants
@p5150j @shannonwells