Transition to a listener-based approach for the dashboard compressor toggle #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5t0n3
force-pushed
the
compressor-update-listener
branch
from
da18a3c
to
f3c18fc
Compare
|
For whatever reason the dashboard toggle wouldn't work after power cycling the robot, so I'm converting this back into a draft until I can figure out why that's happening. |
nolanhergert
approved these changes
Apr 26, 2022
|
I'm still having the same issue even while using a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were enabling/disabling the compressor on every robot loop run, which wasn't really necessary. This PR takes advantage of network tables event listeners instead of repeatedly calling an update method.
I can't really simulate the compressor (or at least I don't know how to), so I'll test this on the real bot when I get a chance before merging. :)