Date of Birth field accepting Future Dates

[Elgayar]

When entering a future date, it should prevent that by alerting the user with an error message, however it doesn't and instead it displays the age in negative. Which is meaningless.

[nileshprasad137]

I'll work on this!

[nileshprasad137]

please assign this to me , as i am unable to assign this to myself @teryhill @tmccormi

[tmccormi]

Done. have a bit of fun...

[nileshprasad137]

@tmccormi Some help needed !
I tried to create a patient but when i click Create new patient after entering credentials in face sheet , nothing was happening . Do I have to fill all all the details in contacts, privacy etc to add a new patient?
Also note that there is no option to select dob from calender like it has in issurance, Refer screenshots below.

EDIT : After filling all the red marked fields , new patient was still not getting created. I think I'll re-setup the project . I just saw a requirement for php.ini file.

EDIT 2: Even after filling all the fields , that button doesn't work.

[teryhill]

Name , sex and DOB should be all that is needed to create a new patient

[nileshprasad137]

@teryhill was there a datepicker like that of an insurance before ,,in dob fields?

[teryhill]

Yes , but now they should be like DOB.

[nileshprasad137]

@teryhill okay , i was on a old version , its getting created now! Sorry for the confusion

[nileshprasad137]

@teryhill @tmccormi Have a look at this.

I modified Jquery file of calender and now it cannot accept any future date .
I guess this solves multiple issues 😉

[teryhill]

What about future dates in appointments and flow board?

…

Sent from my iPhone

On Mar 3, 2017, at 1:21 PM, Nilesh Prasad ***@***.***> wrote: @teryhill @tmccormi Have a look at this. I modified Jquery file of calender and now it cannot accept any future date . I guess this solves multiple issues 😉 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[nileshprasad137]

oops 🙈 I'll correct that.

[teryhill]

If you could give a option to allow future date on demand that would work.

…

Sent from my iPhone

On Mar 3, 2017, at 1:32 PM, Nilesh Prasad ***@***.***> wrote: oops 🙈 I'll correct that. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[nileshprasad137]

@teryhill Or maybe a different jquery calender file for appointments and flowboard though it'll be a bit repetitive. ?

[nileshprasad137]

@teryhill I am a bit stuck up here. Have a look at file https://github.com/LibreHealthIO/LibreEHR/blob/master/interface/new/new.php

See the code from line 231 to 239
<script> $(function() { $("#DOB, #regdate").datetimepicker({ timepicker: false, format: "<?= $DateFormat; ?>" }); $.datetimepicker.setLocale('<?= $DateLocale;?>'); }); </script>

I tried to add a line maxDate:0 for setting up max date to today , but it was not working. And the point to be noted is ** even if you delete this script block , the calender runs fine**, so i think its redundant or something is overriding this script.

Please have a look , and correct me, if I am wrong.

[teryhill]

@nileshprasad137 you are correct that code block has no bearing on the DOB . You need to look at options.inc in the \library directory. I have a change to that program that has not been committed to the code base yet so look at PR 467 . The code you are looking for is from line 364-387

[nileshprasad137]

@teryhill @tmccormi
DOB not accepting future dates and flowboard accepting future dates :simple_smile:

Any more possible loopholes or
Issue resolved ?

[teryhill]

@nileshprasad137 ?PR#

[nileshprasad137]

ok , sending!

[teryhill]

@nileshprasad137 Nice clean fix. It also takes care for deceased date.

[nileshprasad137]

yes , but unfortunately i did'nt create a new Pull request! I merged that with Master so its coming in that pull request #448 . 😔

I'll not do that mistake again.
Is there a possibility of that getting fixed ?
Its time for me to work with different branches .

[teryhill]

@tmccormi can you fix this?

[naveen17797]

@teryhill seems this is the issue i have raised in my current PR, they didnt add server side validation on datepicker