Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to official Gerber reference viewer #215

Closed
dbrgn opened this issue Dec 18, 2017 · 12 comments
Closed

Add link to official Gerber reference viewer #215

dbrgn opened this issue Dec 18, 2017 · 12 comments
Labels

Comments

@dbrgn
Copy link
Member

dbrgn commented Dec 18, 2017

In the docs and in the gerber export dialog you recommend gerbv. However, I've had experiences with gerbv where it would render gerbers on a wrong way (even with examples directly from the reference).

I'd rather recommend Gerbview (part of KiCad, docs here) and/or the online reference viewer.

@ubruhin
Copy link
Member

ubruhin commented Dec 18, 2017

Hmm okay, actually I was happy with gerbv until now (more than with Gerbview). Do you have example files which gerbv doesn't render properly? But yes, the online reference viewer is probably a good candidate to recommend.

@marmei
Copy link

marmei commented Jan 6, 2018

What do you think about kayout? https://github.com/klayoutmatthias/klayout. It is native Qt.

@ubruhin
Copy link
Member

ubruhin commented Jan 6, 2018

What do you think about kayout?

I have never heard about it, so I spent a few minutes to give it a try but unfortunately I was not even able to open a Gerber file with it 😉 Did you try it too?

@marmei
Copy link

marmei commented Jan 6, 2018

Yes Indeed, Klayout is a professional tool for chip design. I used it for MEMS design and it is much better suited than all commercial tools I have tried/provided by my university.
However I do not know if it is straight forward to combine it directly with librePCB. (maybe Mathias from Klayout comes to Fossdem ?! - if we ask him 😎 )

@ubruhin
Copy link
Member

ubruhin commented Jan 6, 2018

OK but I don't see any reason to "combine" it with LibrePCB, it's something completely different. This issue is just about recommending LibrePCB users a Gerber viewer which they could use to review the generated Gerber files. And until now I never saw a better Gerber viewer than gerbv...

@marmei
Copy link

marmei commented Feb 5, 2018

BTW - excellent talk at fosdem!
In my opinion you are are paving the most promising way to create an open source PCB editor in commercial grade.
Just wanted add this link for viewing gerber files in Klayout. http://klayout.de/klayout_screenshot5_pcb.png

@ubruhin
Copy link
Member

ubruhin commented Feb 5, 2018

BTW - excellent talk at fosdem!
In my opinion you are are paving the most promising way to create an open source PCB editor in commercial grade.

Great to hear, thank you! :)

Just wanted add this link for viewing gerber files in Klayout. http://klayout.de/klayout_screenshot5_pcb.png

Sure that this screenshot shows an imported Gerber file?

But anyway, IMO we should keep the current link to gerbv because it is very intuitive, already widely used, and also my own experience with it is very positive. It always worked properly for me. @dbrgn told me that the wrong results he saw might be caused by invalid Gerber data, so not really a fatal bug of the viewer (although it would be better to warn about invalid data).

But adding a link to the official online Gerber viewer is still a good idea, we should add a link (in addition to gerbv to the Gerber export dialog. So this issue is now to add such a link to that dialog.

To also add that link to the documentations, i created LibrePCB/librepcb-doc#2.

@ubruhin ubruhin added the easy label Feb 5, 2018
@dbrgn
Copy link
Member Author

dbrgn commented Feb 6, 2018

Yes, I take back what I said about gerbv :)

@dbrgn dbrgn changed the title Replace references to gerbv Add link to official Gerber reference viewer Feb 6, 2018
@kliment
Copy link
Contributor

kliment commented Feb 7, 2018

I recently implemented something based on libgerbv and it's a bit confusing but not at all difficult. Do we want a libgerbv-based viewer built right into librepcb medium-term?

@ubruhin
Copy link
Member

ubruhin commented Feb 7, 2018

Do we want a libgerbv-based viewer built right into librepcb medium-term?

medium-term or long-term maybe yes, but with very low priority as it's not a big deal to use a standalone Gerber viewer.

@dbrgn
Copy link
Member Author

dbrgn commented Apr 5, 2018

Here's an example where gerbv seems to be wrong:

screenshot

Reference viewer:

screenshot2

@ubruhin
Copy link
Member

ubruhin commented May 11, 2018

This was fixed in #255...

@ubruhin ubruhin closed this as completed May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants