Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add album share to the cover photo's vertical-dot-menu #669

Open
Roebie opened this issue Oct 18, 2022 · 2 comments
Open

Add album share to the cover photo's vertical-dot-menu #669

Roebie opened this issue Oct 18, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@Roebie
Copy link

Roebie commented Oct 18, 2022

Describe the enhancement you'd like
If you go to Menu > Albums > My Albums the you get to see the cover photo of all your user created albums. Each one has a ⋮ (vertical dots) menu in the right upper corner. Clicking it gives you a popup menu of actions you can do with that album. At this moment Rename and Delete are the only two options.
I would like to have Sharing added to it. This action is at this moment only available inside the album (Menu > Albums > My albums > Open an album > Click the ⋮ (three vertical dots) > Album Actions >Sharing), but I feel it deserves a place here.

Describe why this will benefit the LibrePhotos
Sharing is - just like Rename and Delete - an album level action and I feel it would make much sense to have it here (too).
If you have a lot of albums and want to share a major part of them, having the Sharing option here would be a lot faster than having to open each album one by one.

Additional context
I'm not really suggesting to move it here, but rather to add it here.

Thanks

@Roebie Roebie added the enhancement New feature or request label Oct 18, 2022
@5m4u66y
Copy link
Contributor

5m4u66y commented Oct 18, 2022

I agree and also wanted to submit this request

@5m4u66y
Copy link
Contributor

5m4u66y commented Oct 19, 2022

I added the Share action to the album cover actions menu.
I don't know if we should remove it or not from the other menu (it might also still be useful there).

Working on this, I had a deeper look at the Modal Album Share component and it needs a few changes:

  1. The click on the user name is broken and in my opinion we should simply remove it
  2. The users display is messy because we display the time the user joined and the name and this does not fit in the window width. Do we really need the time the user joined in this window? If yes, maybe a Tooltip would be a better option?
  3. The Toggle Switch also toggles the visibility of a share icon. Maybe we should just remove the Toggle Switch and use the icon with two states. Or two icons like for the Photo Share modal. At least we need to be consistent on the UI of those two modals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants