Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement viewing videos #763

Open
derneuere opened this issue Feb 27, 2023 · 2 comments
Open

Implement viewing videos #763

derneuere opened this issue Feb 27, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers mobile

Comments

@derneuere
Copy link
Member

Describe the enhancement you'd like
As a user, I want to be able to watch my videos.

Describe why this will benefit the LibrePhotos
Use react-native-vlc-media-player as this should be very stable and reliable.
@derneuere derneuere added enhancement New feature or request mobile labels Feb 27, 2023
@derneuere derneuere added the good first issue Good for newcomers label Mar 22, 2023
@abdulasiraj
Copy link

'Can I start working on this?

@derneuere
Copy link
Member Author

You have to add the video player here in the ligthbox: https://github.com/LibrePhotos/librephotos-mobile/blob/main/src/Components/LightBox.tsx

And here in the image grid: https://github.com/LibrePhotos/librephotos-mobile/blob/main/src/Components/ImageGrid.js

Photos have a property for the type of file, which you can check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers mobile
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@derneuere @abdulasiraj