Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification tile not working #176

Closed
mueller-ma opened this issue Sep 9, 2017 · 6 comments
Closed

Notification tile not working #176

mueller-ma opened this issue Sep 9, 2017 · 6 comments
Labels
Milestone

Comments

@mueller-ma
Copy link
Contributor

Nothing happens when I tab on the notification tile.
Android 7.1.2
Lineageos 14.1

@smichel17 smichel17 added this to the v3.1.2 milestone Sep 9, 2017
@smichel17 smichel17 added the bug label Sep 9, 2017
@smichel17
Copy link
Member

smichel17 commented Sep 9, 2017

Beat you by a few days: 15f6811 :P

v3.1.2 is released, just waiting on fdroid to push updates

@smichel17
Copy link
Member

Actually, I'll leave this open until it does come out on f-droid, so others don't miss it.

@smichel17 smichel17 reopened this Sep 9, 2017
@mueller-ma
Copy link
Contributor Author

This will toggle the filter?

@smichel17
Copy link
Member

Yeah. There's a helper function to toggle the filter, and I just accidentally swapped on and off while I was refactoring that code (root mode prep). So when the filter is on, tapping the tile currently tries to turn it on again, and the same for when it's off. That commit just swaps it back the way it should be.

@mueller-ma
Copy link
Contributor Author

Because of this tile it might be a good idea to disable the notification

@smichel17
Copy link
Member

The notification is needed for Android memory management, to keep Android from killing the service unless the phone has so little memory that there's no choice. On android 8.0 there is a smaller notification, that we will switch to, if we decide to support 8.0 (#169).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants