Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen navigation bar is not always filtered by Red Moon #252

Open
grooku opened this issue Jun 18, 2019 · 4 comments · May be fixed by #329
Open

Screen navigation bar is not always filtered by Red Moon #252

grooku opened this issue Jun 18, 2019 · 4 comments · May be fixed by #329
Labels
api26+ Low priority. Android 8.0 introduced changes to overlays, and I don't use an 8.0+ device. bug good first issue These issues are relatively simple and self-contained.

Comments

@grooku
Copy link

grooku commented Jun 18, 2019

Red Moon version: 3.4.0
Android version: 9
Device model: Samsung S10

The filter works perfectly fine when I have my phone in portrait mode. However, when I switch to landscape mode the navigation bar becomes unfiltered again.
Portrait mode
Landscape mode:

This issue happens when I start up Red Moon in landscape mode as well.

Thank you for making and working on this app!

@smichel17 smichel17 added the bug label Mar 2, 2020
@smichel17 smichel17 added the api26+ Low priority. Android 8.0 introduced changes to overlays, and I don't use an 8.0+ device. label Mar 4, 2020
@Slion
Copy link

Slion commented Mar 6, 2020

I'm pretty sure I have a solution for that. I'll share a link once the code is online. Feel free to remind me if I forget about it.

@smichel17 smichel17 added the good first issue These issues are relatively simple and self-contained. label Mar 6, 2020
@smichel17
Copy link
Member

Feel free to open a draft PR while you're working on it :)

@Slion
Copy link

Slion commented Mar 7, 2020

I may let you guys do the work as I'm not much of a Red Moon user myself.
However I dealt with that same problem for that project:
https://github.com/Slion/FxService
See home page there:
https://slions.net/resources/fx-service.8/

I just forgot to push the last commit that was fixing that same issue. I'll push it later today when I fire up my computer.

@Slion
Copy link

Slion commented Mar 8, 2020

Here is the commit which fixed that same issue:
Slion/FxService@e6258ca
Just take a look at the latest version of that file for a cleaner code.

The implementation is a bit funny because when trying to have something that made more sense it broke the nav bar again. However it looks like it works fine like this and that's fine by me :)
Hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api26+ Low priority. Android 8.0 introduced changes to overlays, and I don't use an 8.0+ device. bug good first issue These issues are relatively simple and self-contained.
Development

Successfully merging a pull request may close this issue.

3 participants