Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using eventBus instead of onSettingsChangedListener #93

Closed
smichel17 opened this issue Oct 27, 2016 · 2 comments
Closed

Consider using eventBus instead of onSettingsChangedListener #93

smichel17 opened this issue Oct 27, 2016 · 2 comments
Labels
good first issue These issues are relatively simple and self-contained.

Comments

@smichel17
Copy link
Member

For example, sticky events would make dealing with filter state sooo much easier. It's a relatively small DEX count -- around 350 methods.
@raatmarien
Copy link
Member

EventBus looks like a very convenient library, especially for broadcasting setting changes. However, I don't have the time to implement it in the codebase.

@raatmarien raatmarien added enhancement good first issue These issues are relatively simple and self-contained. labels Oct 30, 2016
@smichel17 smichel17 mentioned this issue Oct 30, 2016
Closed
10 tasks
@raatmarien
Copy link
Member

This has been done by #95, which has been merged, so I'll close this issue 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue These issues are relatively simple and self-contained.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smichel17 @raatmarien