Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

heltour picks up wrong (old) game #498

Open
glbert-does opened this issue Mar 29, 2023 · 1 comment · May be fixed by #524
Open

heltour picks up wrong (old) game #498

glbert-does opened this issue Mar 29, 2023 · 1 comment · May be fixed by #524
Assignees
@glbert-does
Labels
bug P3 - low Minor improvement to league experience (small ui glitch, spelling error, etc.)

Comments

@glbert-does
Copy link
Member

in this pairing S34 R5:
https://www.lichess4545.com/admin/tournament/playerpairing/77380/change/
heltour accidentally picked up the wrong game – https://lichess.org/LQJheBZu – which was actually played months earlier for S33 R6:
https://www.lichess4545.com/admin/tournament/playerpairing/75410/change/
(same players, same colours)

this is a rare bug, definitely does not happen every time we get a repeat pairing. i believe i remember it happening before once, but i might be mistaken.

we fixed the problem manually by replacing the game link.
@glbert-does glbert-does added bug P3 - low Minor improvement to league experience (small ui glitch, spelling error, etc.) labels Mar 29, 2023
@glbert-does
Copy link
Member Author

glbert-does commented Sep 8, 2023 •
edited

not sure why this happened in these specific games, but maybe get_latest_game_metas in lichessapi.py should have an additional parameter for the round start and send a query parameter "since" to lichess as well, so we only receive games since the round started. that might be a good idea anyway.

edit: while we are at it, maybe we should add an additional filter "vs" as well, since we are only interested in games against one user. see https://lichess.org/api#tag/Games/operation/apiGamesUser
for details.

edit 2: get_latest_game_metas is called from update_tv_state in tasks.py

@glbert-does glbert-does self-assigned this Nov 1, 2023
@glbert-does glbert-does linked a pull request Nov 2, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glbert-does glbert-does

Labels
bug P3 - low Minor improvement to league experience (small ui glitch, spelling error, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

more filters when requesting game metas glbert-does/heltour
1 participant
@glbert-does