Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Success message after failed commit #51

Open
FlorianBeerRB opened this issue Apr 8, 2022 · 4 comments
Open

Success message after failed commit #51

FlorianBeerRB opened this issue Apr 8, 2022 · 4 comments

Comments

@FlorianBeerRB
Copy link
Collaborator

Merge workflow sends "done" message when model merge worked but creation of commit failed

@danielsiegl
Copy link
Collaborator

danielsiegl commented Apr 21, 2022

I guess this should be solved - only "issue" the Action run is green:
https://github.com/LieberLieber/LemonTree.Automation.Workflows/actions/runs/2204140805
but the Exit Code of LTA is 3

But it reports correctly in the pull request now:
#72 (comment)

@danielsiegl
Copy link
Collaborator

Rebase is still confusing: #92

@FlorianBeerRB
Copy link
Collaborator Author

I'd suggest to set the job to failed only if the integrator, CI responsible, model custodian needs to check.
If the merge or rebase fails due to merge conflicts or missing user rights, the users get the feedback in the comments and can take care by themselves.
If the merge fails due to license issues, file not found, PAT issue, ... some admin has to take care. Then the workflow should fail

@danielsiegl
Copy link
Collaborator

Agree!

I'd suggest to set the job to failed only if the integrator, CI responsible, model custodian needs to check. If the merge or rebase fails due to merge conflicts or missing user rights, the users get the feedback in the comments and can take care by themselves. If the merge fails due to license issues, file not found, PAT issue, ... some admin has to take care. Then the workflow should fail

Ok - for those jobs - but I like "consistency" check to turn "red"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants