Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forever authenticated #131

Open
jfk9w opened this issue Dec 10, 2022 · 2 comments
Open

Forever authenticated #131

jfk9w opened this issue Dec 10, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@jfk9w
Copy link

jfk9w commented Dec 10, 2022

Describe the bug

  1. It looks like 2FA does not expire until server restart (or takes very long to expire).
  2. Also you can still open doors (and maybe use some activated items, I haven't checked) when not authenticated.

How To Reproduce

  1. Start the server with 2FA.
  2. Authenticate.
  3. Log out.
  4. Log in again. You will not be prompted anything from 2FA plugin. "require-when.on-ip-change" and "require-when.every-login" configuration properties are ignored.

Expected behavior
Player authentication should expire on quit.

Server Information
Server Java and OS

  • Java Runtime Version: 17.0.5+8
  • OS: Linux

Server Plugins

  • LuckPerms | 5.4.54 | Enabled: true
  • PrometheusExporter | 2.5.0 | Enabled: true
  • 2FA | 1.6.3 | Enabled: true

Server Jar, Versions and Information

  • Spigot Build version: git-Paper-307 (MC: 1.19.2)
  • Server Version: 1.19.2-R0.1-SNAPSHOT
  • Version Instance: v1_19_2
  • NMSVersion Instance: v1_19_R1
  • Max Memory: 4294 MB
  • Free Memory: 2247 MB
  • Total Memory: 4294 MB

Communication Method & Proxies:

  • Using Bungeecord: false
  • Is Proxy Loaded: false
  • Communication Method in config: NONE
  • Communication Timeout in config: 30 ticks

Storage Information:

  • Type of Storage: JSON
  • Is external Storage loaded: false

Additional context
It looks like onPlayerQuit is not called for some reason.

@jfk9w jfk9w added the bug Something isn't working label Dec 10, 2022
@LoneDevilX
Copy link

Same issue over here

@StKillReal
Copy link

Issue is still here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants