show entire code when pasting #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not too familiar with such flow. Is it possible for you to send me a video how it works, please? |
|
@LiewJunTung, Take a look at this GIF confirming that this fix works. Looking forward to seeing this fix merged! @mozesma, Thank you! |
|
I see, alright. I'll believe you @agacia . 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on iOS device when you start an OTP flow (SMS verification) and you get the SMS, the keyboard will suggest the use the code from the SMS, tapping that suggestion will paste the code in the PinCodeTextField.
the logic works, but visually in this case you will only see the last digit on the last place, and the rest of the fields will remain empty.
this fix makes it so whenever a text is change it will fill all of the input text from the last known position up to the text.length, therefore resolving the above issue