Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace yew_services to yew::services #1

Closed
m-s-h-1 opened this issue Feb 24, 2021 · 3 comments
Closed

Replace yew_services to yew::services #1

m-s-h-1 opened this issue Feb 24, 2021 · 3 comments
Labels
good first issue Good for newcomers

Comments

@m-s-h-1
Copy link

m-s-h-1 commented Feb 24, 2021

In main.rs line 143, it is written yew_services. Please change it to yew::services. Also, comment out yew_services in cargo.toml and the path to yew should not be there. There just "" these are fine. With a path, it does not compile on linux and with your specific path, it would not compile on any other pc :) 👍 .

@LighghtEeloo LighghtEeloo added the good first issue Good for newcomers label Feb 25, 2021
@LighghtEeloo
Copy link
Owner

LighghtEeloo commented Feb 25, 2021

Yeah, you are right. This version is still under heavy development and is currently using yew from its master branch (which is supposed to be 0.18 in the future). So I maintain a version of yew locally, which is why you're seeing the path.

For now if you are trying to run it yourself, you can:

  1. Choose branch tracer-yew-lock.
  2. Git clone yew and choose the master branch.
  3. Change the path in Cargo.toml.

But anyway, in the short future I may:

A. take your advice and use yew 0.17 instead, meaning using yew::services.
B. wait until yew 0.18 come out and update Cargo.toml

either way you'll no longer worry about "local path".

@LighghtEeloo
Copy link
Owner

In fact, this situation is caused because I'm lazy ( yeah ) and don't want to change my code in the future:
yewstack/yew#1693

@LighghtEeloo
Copy link
Owner

commit 96846dd (already committed on branch dev) has fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants