Skip to content
This repository has been archived by the owner on Oct 21, 2022. It is now read-only.

Can't undo workspace wide search & replace #1547

Open
majnu opened this issue Jul 5, 2014 · 3 comments
Open

Can't undo workspace wide search & replace #1547

majnu opened this issue Jul 5, 2014 · 3 comments

Comments

@majnu
Copy link

majnu commented Jul 5, 2014

In the searcher I pressed "all" by accident while the replace box was empty. All occurrences of the searched text were wiped from all files in my workspace with no possibility to undo the change. The regular undo did not work for this.

@cldwalker
Copy link
Member

Thanks for the report. Agreed I'd love something like this as well. We don't have the bandwidth to currently work on this. For anyone interested in looking into this, one possible solution could be to wrap the replace with a snapshot of the contents of all paths about to be replaced.

@cldwalker
Copy link
Member

Since that last suggestion may not scale well for a large number of files, it may be worth finding a replace.js replacement that does this

@shamrin
Copy link
Contributor

shamrin commented Nov 28, 2014

@cldwalker I agree that workspace wide undo is clearly an enhancement. On the other hand, we should make it obvious that clicking "all" destroys data. I would argue it's UX bug. See #1753 for details.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

4 participants