Skip to content
This repository has been archived by the owner on Oct 21, 2022. It is now read-only.

Naming of source and website UI components #2290

Open
chrisetheridge opened this issue Nov 9, 2016 · 2 comments
Open

Naming of source and website UI components #2290

chrisetheridge opened this issue Nov 9, 2016 · 2 comments
Labels

Comments

@chrisetheridge
Copy link
Contributor

I think we should settle on one word, to represent the authors website (or repository), for a plugin. Right now, we use website and source interchangeably. See this thread for more information.

I'm happy to refactor the CSS and CLJS to use one word, such as website, to represent the plugin website. Only issue I can think of with this, though, is that some CSS classes may use source as their identifiers, or part of their identifiers. I've yet to do an audit on these though.

@sbauer322
Copy link
Contributor

My vote is for website... but it would be nice to hear from others before you get started on anything so as to prevent possibly wasting your time.

@cldwalker
Copy link
Member

defui components are rarely used by user plugins so a small number of changes there to be consistent is reasonable. We shouldn't be changing css classes unless we know they have no effect on themes or a plan to deprecate. Looking at themes LT ships is a starting point. Then, you should be looking at user plugins named *theme

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants