Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Banker NPC / Villager Job #143

Closed
jasons49 opened this issue Sep 3, 2023 · 3 comments
Closed

Feature Request: Banker NPC / Villager Job #143

jasons49 opened this issue Sep 3, 2023 · 3 comments
Assignees
Labels
Enhancement New feature or request Thematic issues Suggestion would not fit the core Vanilla+ theme of Lightman's Currency

Comments

@jasons49
Copy link

jasons49 commented Sep 3, 2023

I just wanted to say I've banged my head on the wall for how many times I've messed up where this request belongs I'm very sorry for the headache my stupidity has caused.

Is your feature request related to a problem? Please describe.
My server's theme is Medieval to Rennaissance and we love this mod except for the modern items, now we've removed the recipes for most of those items so they can't be crafted, but the ATM ans Mint IS also too modern.

Describe the solution you'd like
What would be awesome that could be a good alternative for those non-modern server's is a

  • Banker NPC
  • Or a Villager profession called Banker (their job allows you to access your bank account when you interact with them)
  • allowing for something like a grand exchange or Bank (without being modern)
    For the Mint item an alternative would be
    -Add Banker npc
  • Or villager profession called a minter,
  • or add minting as an ability that the Banker NPC or Villager profession can do when you give them metal ingots vs putting them in your bank account.

Describe alternatives you've considered
I've considered other mods but lightman's is the best of the currency mods that don't add modern currency or anything game breaking. I'd also considered old timey looking items to be alternatives to the modern mint and ATM but I don't know what they would be other than what I've suggested.

Additional context
Mods that add more villager jobs are "More villger professions", "More villagers".

@jasons49 jasons49 added the Enhancement New feature or request label Sep 3, 2023
@Lightman314
Copy link
Owner

Lightman314 commented Sep 22, 2023

Unfortunately my mod already adds a banker villager, so it'd be extremely confusing to add another.
Also, adding a banker NPC of any variety would be extremely inconvenient as the ATM's features are something that should be easily accessible to anyone (as it is in its current state, as the ATM can be crafted with fairly common resources), and unless the NPC was somehow craftable, it's not a realistic solution to the problem.

As far as I can see, the easiest and best solution would simply be to make a resource pack that changes the models/textures of the ATM, Coin Mint, etc to be more "lore friendly". This is something I could probably do at some point (and the next build of LC will include an optional built-in resource pack of a different type), but I'm not exactly the best artist or model designer, so if you want something like this done in a timely manner, all I can suggest is to either make a resource pack yourself, or request someone else to do it for you.

@Lightman314 Lightman314 added the Thematic issues Suggestion would not fit the core Vanilla+ theme of Lightman's Currency label Oct 4, 2023
@RaidenKoizuma
Copy link

Hey! Just popping in here to say I'm also in the same boat with having vending machines and terminals and such be out of theme for a medieval-like modpack. This is really the most feature complete currency mod probably ever so we're not gonna be switching it out or anything. But I would def appreciate alternatives to/resource pack for such "technology focused" blocks/items. Maybe if they were magic themed it'd be more generalizable to more modpacks? Just my 2 cents, thanks for the great mod!

@Lightman314 Lightman314 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 6, 2024
@Lightman314
Copy link
Owner

As much as I understand your concerns with theming, this issue seems like it can easily be solved with a proper resource pack that remodels and/or re-textures the ATM and other problematic blocks that don't fit the theme with their default textures (or for the vending machines, simply using CraftTweaker to disable their recipes and hiding them from JEI, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Thematic issues Suggestion would not fit the core Vanilla+ theme of Lightman's Currency
Projects
None yet
Development

No branches or pull requests

3 participants