Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cityscapes DataModule + clean up DM docs #136

Merged
merged 26 commits into from Aug 5, 2020
Merged

Add Cityscapes DataModule + clean up DM docs #136

merged 26 commits into from Aug 5, 2020

Conversation

InCogNiTo124
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #135.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from Borda August 3, 2020 12:31
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #136 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   91.32%   91.30%   -0.03%     
==========================================
  Files          86       84       -2     
  Lines        4174     4049     -125     
==========================================
- Hits         3812     3697     -115     
+ Misses        362      352      -10     
Flag Coverage Δ
#unittests 91.30% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/datamodules/sklearn_datamodule.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 156fc65...b32b917. Read the comment docs.

@InCogNiTo124
Copy link
Contributor Author

Due to technical reasons (uncorrelated with this PR) I'm unable to test this, can somebody please try it out?

@williamFalcon
Copy link
Contributor

williamFalcon commented Aug 4, 2020

Awesome.

  1. Can you add to the docs.
  2. Can you add the generator argument to the random_split function?

@Borda Borda added the enhancement New feature or request label Aug 5, 2020
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, just add Docs and source reference

@mergify
Copy link
Contributor

mergify bot commented Aug 5, 2020

This pull request is now in conflict... :(

@williamFalcon williamFalcon changed the title Add Cityscapes DataModule Add Cityscapes DataModule + clean up DM docs Aug 5, 2020
@williamFalcon
Copy link
Contributor

@InCogNiTo124 awesome PR! Looking forward to more datamodules :)

@williamFalcon williamFalcon merged commit f6215eb into Lightning-Universe:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Cityscapes DataModule
3 participants