Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BYOL implementation #144

Merged
merged 13 commits into from Aug 5, 2020
Merged

BYOL implementation #144

merged 13 commits into from Aug 5, 2020

Conversation

annikabrundyn
Copy link
Contributor

Closes #114

@pep8speaks
Copy link

pep8speaks commented Aug 5, 2020

Hello @annikabrundyn! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-08-05 16:13:07 UTC

@mergify mergify bot requested a review from Borda August 5, 2020 14:49
@annikabrundyn
Copy link
Contributor Author

FYI @ananyahjha93 @vladisai - still finishing this up :)

@annikabrundyn annikabrundyn marked this pull request as draft August 5, 2020 14:52
@annikabrundyn annikabrundyn changed the title WIP BYOL implementation BYOL implementation Aug 5, 2020
@annikabrundyn annikabrundyn marked this pull request as ready for review August 5, 2020 15:20
@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #144 into master will increase coverage by 0.19%.
The diff coverage is 98.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   91.11%   91.30%   +0.19%     
==========================================
  Files          82       85       +3     
  Lines        4039     4142     +103     
==========================================
+ Hits         3680     3782     +102     
- Misses        359      360       +1     
Flag Coverage Δ
#unittests 91.30% <98.05%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...l_bolts/models/self_supervised/byol/byol_module.py 96.42% <96.42%> (ø)
pl_bolts/callbacks/self_supervised.py 100.00% <100.00%> (ø)
pl_bolts/models/self_supervised/__init__.py 100.00% <100.00%> (ø)
pl_bolts/models/self_supervised/byol/models.py 100.00% <100.00%> (ø)
pl_bolts/optimizers/layer_adaptive_scaling.py 94.00% <0.00%> (+2.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f409d5e...352e140. Read the comment docs.

@ananyahjha93 ananyahjha93 self-requested a review August 5, 2020 16:06
@williamFalcon williamFalcon merged commit 0a4f0ae into master Aug 5, 2020
@Borda Borda deleted the byol branch August 5, 2020 17:49
@Borda Borda added the enhancement New feature or request label Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BYOL
4 participants