Modularize AE & VAE #196
Modularize AE & VAE #196
Conversation
|
Hello @nateraw! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-09-10 23:13:07 UTC |
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
==========================================
- Coverage 89.98% 89.55% -0.43%
==========================================
Files 74 74
Lines 3284 3284
==========================================
- Hits 2955 2941 -14
- Misses 329 343 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| decoder = Decoder(hidden_dim, latent_dim, w, h, c) | ||
| # c, h, w = self.img_dim | ||
| decoder = Decoder( | ||
| hidden_dim, latent_dim, self.hparams.input_width, self.hparams.input_height, self.hparams.input_channels |
There was a problem hiding this comment.
let's keep this order if it is everywhere else
There was a problem hiding this comment.
it should be c, h, w right? I started switching over to that from 'c, w, h', which is wrong, if I'm not mistaken? (that's what I kept seeing in this file, but I believe its mixed up)
There was a problem hiding this comment.
just see that the order is different in several places...
| dm_cls = STL10DataModule | ||
| elif script_args.dataset == "imagenet": | ||
| dm_cls = ImagenetDataModule | ||
|
|
There was a problem hiding this comment.
let's add else and raise an error?
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
AE only working on dms with one channel. Also the use of datamodule is confusing, so tryin to clear it up. WIP for now, pls ignore the sketchiness until I mark this as ready 😄
Before submitting
What does this PR do?
Fixes # (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃