Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kitti Datamodule #248

Merged
merged 28 commits into from Sep 27, 2020
Merged

Kitti Datamodule #248

merged 28 commits into from Sep 27, 2020

Conversation

annikabrundyn
Copy link
Contributor

adding Kitti dataset and datamodule for semantic segmentation

note - this requires downloading the dataset first from this link

@pep8speaks
Copy link

pep8speaks commented Sep 23, 2020

Hello @annikabrundyn! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-09-23 18:45:35 UTC

@mergify mergify bot requested a review from Borda September 23, 2020 16:22
@annikabrundyn annikabrundyn changed the title WIP: Kitti dm WIP: Kitti datamodule Sep 23, 2020
@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #248 into master will decrease coverage by 0.57%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
- Coverage   88.31%   87.74%   -0.58%     
==========================================
  Files          70       72       +2     
  Lines        3407     3533     +126     
==========================================
+ Hits         3009     3100      +91     
- Misses        398      433      +35     
Flag Coverage Δ
#cpu 31.92% <0.00%> (-0.71%) ⬇️
#pytest 31.92% <0.00%> (-0.71%) ⬇️
#unittests 87.00% <33.33%> (-0.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/datamodules/kitti_dataset.py 30.43% <30.43%> (ø)
pl_bolts/datamodules/__init__.py 100.00% <100.00%> (ø)
pl_bolts/utils/arguments.py 96.15% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2cdad7...a0fa356. Read the comment docs.

@Borda Borda added datamodule Anything related to datamodules enhancement New feature or request labels Sep 23, 2020
@Borda Borda requested a review from nateraw September 23, 2020 18:21
@annikabrundyn
Copy link
Contributor Author

Hey!
I'm trying to write a test for this datamodule but I'm not sure how to write a general test given that you have to first download the data from the website and then provide the path to the datamodule.
Any chance you could help share an example of how I should implement this test? :)

@annikabrundyn annikabrundyn marked this pull request as ready for review September 23, 2020 19:09
@annikabrundyn annikabrundyn changed the title WIP: Kitti datamodule Kitti Datamodule Sep 23, 2020
@williamFalcon williamFalcon merged commit 32139f4 into master Sep 27, 2020
@Borda Borda deleted the kitti_dm branch September 27, 2020 08:26
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test for this datamodule?

@nateraw nateraw mentioned this pull request Oct 7, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodule Anything related to datamodules enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants