Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports in datamodules #303

Merged
merged 2 commits into from Oct 23, 2020
Merged

Fix imports in datamodules #303

merged 2 commits into from Oct 23, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 23, 2020

What does this PR do?

Fixes
>>> from pl_bolts.datamodules import STL10DataModule

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@Borda Borda added fix fixing issues... Priority High priority task labels Oct 23, 2020
@pep8speaks
Copy link

pep8speaks commented Oct 23, 2020

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 馃嵒

Comment last updated at 2020-10-23 15:00:52 UTC

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #303 into master will decrease coverage by 0.07%.
The diff coverage is 73.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
- Coverage   81.95%   81.87%   -0.08%     
==========================================
  Files          99       99              
  Lines        5503     5534      +31     
==========================================
+ Hits         4510     4531      +21     
- Misses        993     1003      +10     
Flag Coverage 螖
#cpu 24.31% <57.14%> (+0.84%) 猬嗭笍
#pytest 24.31% <57.14%> (+0.84%) 猬嗭笍
#unittests 81.26% <63.26%> (-0.15%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
pl_bolts/datasets/imagenet_dataset.py 18.45% <12.50%> (-1.67%) 猬囷笍
pl_bolts/datamodules/__init__.py 88.00% <82.85%> (-12.00%) 猬囷笍
pl_bolts/datasets/__init__.py 100.00% <100.00%> (酶)
pl_bolts/datasets/ssl_amdim_datasets.py 75.00% <100.00%> (-1.32%) 猬囷笍
pl_bolts/models/__init__.py 100.00% <100.00%> (酶)
pl_bolts/models/vision/__init__.py 100.00% <100.00%> (酶)
pl_bolts/models/vision/segmentation.py 65.38% <100.00%> (酶)
...l_bolts/models/self_supervised/swav/swav_module.py 73.50% <0.00%> (-0.86%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 1fc40bf...4fd4603. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix fixing issues... Priority High priority task
Development

Successfully merging this pull request may close these issues.

None yet

2 participants