Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary mnist dm fix #377

Merged
merged 6 commits into from Nov 19, 2020
Merged

binary mnist dm fix #377

merged 6 commits into from Nov 19, 2020

Conversation

annikabrundyn
Copy link
Contributor

@annikabrundyn annikabrundyn commented Nov 18, 2020

Fixes dataset not found error mentioned in issue #353

Reran the notebook that produced the error and it's now working:

https://colab.research.google.com/drive/1PHwAm48SNojrYbQWPeihmsbWuH-h6KU8#scrollTo=Kh5dXKO4Tr8Y

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #377 (0d71c09) into master (77ff983) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
+ Coverage   81.18%   81.22%   +0.03%     
==========================================
  Files         100      100              
  Lines        5715     5714       -1     
==========================================
+ Hits         4640     4641       +1     
+ Misses       1075     1073       -2     
Flag Coverage Δ
cpu 24.27% <100.00%> (-0.02%) ⬇️
pytest 24.27% <100.00%> (-0.02%) ⬇️
unittests 80.50% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lts/models/self_supervised/simclr/simclr_module.py 71.49% <ø> (-0.14%) ⬇️
.../models/self_supervised/simclr/simclr_finetuner.py 100.00% <100.00%> (ø)
pl_bolts/datasets/base_dataset.py 100.00% <0.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77ff983...b5b3297. Read the comment docs.

@annikabrundyn annikabrundyn marked this pull request as ready for review November 18, 2020 17:06
@annikabrundyn annikabrundyn changed the title [WIP] binary mnist datamodule binary mnist dm fix Nov 18, 2020
@annikabrundyn annikabrundyn added the datamodule Anything related to datamodules label Nov 18, 2020
@annikabrundyn annikabrundyn requested review from williamFalcon and Borda and removed request for williamFalcon November 18, 2020 18:01
@annikabrundyn annikabrundyn added the fix fixing issues... label Nov 18, 2020
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the swift action :]

@Borda Borda added the ready label Nov 19, 2020
@Borda
Copy link
Member

Borda commented Nov 19, 2020

@akihironitta it seems that the Dataset caching does not work as expected or we shall not download it if it already exists...
just most of the tests failed because of

UNEXPECTED EXCEPTION: RuntimeError('Failed download from https://www.cs.toronto.edu/~kriz/cifar-10-python.tar.gz')

@Borda Borda merged commit fa5a944 into master Nov 19, 2020
@Borda Borda deleted the fix_binary_mnist_dm branch November 19, 2020 08:35
@akihironitta
Copy link
Contributor

@Borda I'll dig into it :]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodule Anything related to datamodules fix fixing issues... ready
Development

Successfully merging this pull request may close these issues.

None yet

3 participants