Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pl_bolts.callbacks #477

Merged
merged 6 commits into from Jan 2, 2021

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Dec 24, 2020

What does this PR do?

Follow-up PR of #338.

  • adds missing imports and __all__ in pl_bolts/callbacks/__init__.py
  • defines _WANDB_AVAILABLE in pl_bolts/utils/__init__.py
  • uses _*_AVAILABLE variables defined in Refactor pl_bolts.datamodules and pl_bolts.datasets聽#338 for optional package imports
  • uses pragma: no cover instead of pragma: no-cover

If the above changes are too many in a single PR, I'll split this PR into some.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@akihironitta akihironitta added this to In progress in Code Health / Refatoring via automation Dec 24, 2020
@codecov
Copy link

codecov bot commented Dec 24, 2020

Codecov Report

Merging #477 (06914df) into master (a72766c) will increase coverage by 0.11%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #477      +/-   ##
==========================================
+ Coverage   80.52%   80.63%   +0.11%     
==========================================
  Files         103      102       -1     
  Lines        5710     5769      +59     
==========================================
+ Hits         4598     4652      +54     
- Misses       1112     1117       +5     
Flag Coverage 螖
cpu 25.29% <77.77%> (-0.07%) 猬囷笍
pytest 25.29% <77.77%> (-0.07%) 猬囷笍
unittests 80.20% <72.22%> (+0.11%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
pl_bolts/callbacks/data_monitor.py 89.28% <66.66%> (-1.46%) 猬囷笍
pl_bolts/callbacks/variational.py 95.65% <80.00%> (-2.03%) 猬囷笍
pl_bolts/callbacks/__init__.py 100.00% <100.00%> (酶)
pl_bolts/callbacks/ssl_online.py 96.29% <100.00%> (-3.71%) 猬囷笍
pl_bolts/utils/__init__.py 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a72766c...06914df. Read the comment docs.

@akihironitta akihironitta changed the title Refactor callbacks [wip] Refactor pl_bolts.callbacks [wip] Dec 24, 2020
@akihironitta akihironitta changed the title Refactor pl_bolts.callbacks [wip] Refactor pl_bolts.callbacks Dec 24, 2020
@akihironitta akihironitta marked this pull request as ready for review December 24, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants