Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct num_rows calculation in LatentDimInterpolator callback #573

Merged
merged 3 commits into from
Mar 9, 2021

Conversation

FlorianMF
Copy link
Contributor

What does this PR do?

It corrects the calculation of num_rows in the LatentDimInterpolator callback.
Instead of using the range [range_start, range_end] num_rows is calculated based on the number of steps.

Fixes #571

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #573 (f9c0827) into master (4d194d4) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
- Coverage   76.97%   76.97%   -0.01%     
==========================================
  Files         117      117              
  Lines        6836     6835       -1     
==========================================
- Hits         5262     5261       -1     
  Misses       1574     1574              
Flag Coverage Δ
cpu 26.20% <0.00%> (+<0.01%) ⬆️
pytest 26.20% <0.00%> (+<0.01%) ⬆️
unittests 76.45% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/callbacks/variational.py 95.83% <100.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d194d4...c0694d7. Read the comment docs.

@Borda
Copy link
Member

Borda commented Mar 4, 2021

@ananyahjha93 mind check it

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, mind double-check after me @ananyahjha93

@Borda Borda enabled auto-merge (squash) March 6, 2021 21:06
@Borda Borda added the ready label Mar 6, 2021
@Borda Borda merged commit 6b17e1f into Lightning-Universe:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LatentDImInterpolator change num_images calculation
3 participants