Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor setup #601

Merged
merged 7 commits into from Mar 20, 2021
Merged

refactor setup #601

merged 7 commits into from Mar 20, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 19, 2021

What does this PR do?

restructure setup, make it type friendly

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the enhancement New feature or request label Mar 19, 2021
@pep8speaks
Copy link

pep8speaks commented Mar 19, 2021

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-03-19 23:39:29 UTC

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 19, 2021
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #601 (28ba1b1) into master (9b7fdf8) will decrease coverage by 1.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
- Coverage   26.30%   25.20%   -1.11%     
==========================================
  Files         117      118       +1     
  Lines        6838     7119     +281     
==========================================
- Hits         1799     1794       -5     
- Misses       5039     5325     +286     
Flag Coverage Δ
cpu 25.20% <100.00%> (-1.11%) ⬇️
pytest 25.20% <100.00%> (-1.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/__init__.py 100.00% <100.00%> (+9.52%) ⬆️
pl_bolts/info.py 100.00% <100.00%> (ø)
pl_bolts/setup_tools.py 93.33% <100.00%> (-0.42%) ⬇️
...bolts/models/self_supervised/amdim/amdim_module.py 38.84% <0.00%> (-6.79%) ⬇️
...models/detection/faster_rcnn/faster_rcnn_module.py 25.00% <0.00%> (-3.79%) ⬇️
...ts/models/autoencoders/basic_ae/basic_ae_module.py 22.98% <0.00%> (-3.68%) ⬇️
...l_bolts/models/self_supervised/byol/byol_module.py 22.91% <0.00%> (-3.59%) ⬇️
pl_bolts/models/mnist_module.py 28.94% <0.00%> (-3.41%) ⬇️
pl_bolts/models/vision/segmentation.py 24.13% <0.00%> (-3.32%) ⬇️
pl_bolts/models/vision/image_gpt/igpt_module.py 19.78% <0.00%> (-3.30%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fb2ba7...28ba1b1. Read the comment docs.

@Borda Borda merged commit 6bdc3f2 into master Mar 20, 2021
@Borda Borda deleted the refactor/setup branch March 20, 2021 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants