Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix tests #618

Merged
merged 11 commits into from
Apr 17, 2021
Merged

CI: fix tests #618

merged 11 commits into from
Apr 17, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Apr 8, 2021

What does this PR do?

incorrectly failing stats results
Screenshot 2021-04-08 at 19 26 37

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the ci/cd Continues Integration and delivery label Apr 8, 2021
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #618 (e6a10b0) into master (5995889) will increase coverage by 46.83%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #618       +/-   ##
===========================================
+ Coverage   25.37%   72.21%   +46.83%     
===========================================
  Files         118      118               
  Lines        7093     7129       +36     
===========================================
+ Hits         1800     5148     +3348     
+ Misses       5293     1981     -3312     
Flag Coverage Δ
cpu 72.21% <100.00%> (+46.83%) ⬆️
pytest 72.21% <100.00%> (+46.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/__about__.py 100.00% <100.00%> (ø)
pl_bolts/losses/self_supervised_learning.py 71.33% <0.00%> (+0.18%) ⬆️
pl_bolts/models/self_supervised/cpc/cpc_module.py 20.58% <0.00%> (+0.58%) ⬆️
pl_bolts/models/vision/image_gpt/igpt_module.py 20.65% <0.00%> (+0.87%) ⬆️
pl_bolts/datasets/imagenet_dataset.py 20.00% <0.00%> (+1.50%) ⬆️
pl_bolts/datasets/kitti_dataset.py 34.61% <0.00%> (+1.92%) ⬆️
pl_bolts/callbacks/vision/confused_logit.py 26.02% <0.00%> (+4.10%) ⬆️
pl_bolts/callbacks/printing.py 71.18% <0.00%> (+6.77%) ⬆️
pl_bolts/models/rl/common/cli.py 11.76% <0.00%> (+11.76%) ⬆️
pl_bolts/models/self_supervised/amdim/datasets.py 56.89% <0.00%> (+12.06%) ⬆️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5995889...e6a10b0. Read the comment docs.

@Borda
Copy link
Member Author

Borda commented Apr 17, 2021

seems to be connected with installing pre-release coverage==5.6b1

@Borda Borda merged commit c2e2577 into master Apr 17, 2021
@Borda Borda deleted the ci/tests branch April 17, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continues Integration and delivery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant