Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type annotation of ExperienceSource.__iter__ #645

Merged
merged 1 commit into from May 14, 2021
Merged

Fix type annotation of ExperienceSource.__iter__ #645

merged 1 commit into from May 14, 2021

Conversation

t-vi
Copy link
Contributor

@t-vi t-vi commented May 14, 2021

Fixes #644

iter returns Iterator

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

@github-actions github-actions bot added the datamodule Anything related to datamodules label May 14, 2021
@Borda Borda merged commit 5bfb846 into Lightning-Universe:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@akihironitta akihironitta Awaiting requested review from akihironitta

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

Assignees
No one assigned
Labels
datamodule Anything related to datamodules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doesn't built on Python 3.9 / PyTorch master due to wrong type annotations
2 participants
@t-vi @Borda