Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.6 support #785

Merged
merged 10 commits into from Dec 19, 2021
Merged

Drop Python 3.6 support #785

merged 10 commits into from Dec 19, 2021

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Dec 18, 2021

What does this PR do?

1.4.8 Dropping Python 3.6 support should fix the failing tests as commented in #529 (comment).

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes?
  • [n/a] Did you write any new necessary tests? [not needed for typos/docs]
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@akihironitta akihironitta added the ci/cd Continues Integration and delivery label Dec 18, 2021
@Borda
Copy link
Member

Borda commented Dec 18, 2021

as chatted, lest rather bump the python version to 3.7 than set too tight PL version range...

@akihironitta akihironitta changed the title Update requirements.txt with pytorch-lightning>=1.4.8 Update Python versions in CI Dec 18, 2021
@akihironitta akihironitta changed the title Update Python versions in CI Set min Python version to 3.7 Dec 18, 2021
@akihironitta akihironitta changed the title Set min Python version to 3.7 Drop Python 3.6 support Dec 18, 2021
@akihironitta
Copy link
Contributor Author

akihironitta commented Dec 18, 2021

Once the running CI is all green, this PR should be ready for getting merged.

UPDATE: All runs are successful 馃帀

@mergify mergify bot added the ready label Dec 19, 2021
@Borda Borda merged commit f8972df into master Dec 19, 2021
@Borda Borda deleted the ci/pl-1.4.8 branch December 19, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continues Integration and delivery ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants