Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename flag to_review -> under_review #837

Merged
merged 1 commit into from Jul 20, 2022
Merged

Rename flag to_review -> under_review #837

merged 1 commit into from Jul 20, 2022

Conversation

otaj
Copy link
Contributor

@otaj otaj commented Jul 20, 2022

What does this PR do?

As a followup to #835, this is an iteration on proper name for the flag.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@github-actions github-actions bot added callback datamodule Anything related to datamodules documentation Improvements or additions to documentation model labels Jul 20, 2022
@Borda Borda enabled auto-merge (squash) July 20, 2022 15:22
@mergify mergify bot added the ready label Jul 20, 2022
@Borda Borda merged commit cb4bcc2 into master Jul 20, 2022
@Borda Borda deleted the rename_flag branch July 20, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callback datamodule Anything related to datamodules documentation Improvements or additions to documentation model ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants