Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests, updated doc-strings for Dummy Datasets #865

Merged
merged 9 commits into from Aug 16, 2022
Merged

Added tests, updated doc-strings for Dummy Datasets #865

merged 9 commits into from Aug 16, 2022

Conversation

nishantb06
Copy link
Contributor

@nishantb06 nishantb06 commented Aug 15, 2022 •
edited

What does this PR do?

Part of #839

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

otaj
otaj approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@otaj otaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, it looks good, thanks! I left couple comments ⚡

.gitignore Outdated Show resolved Hide resolved
tests/datasets/test_datasets.py Outdated Show resolved Hide resolved
pl_bolts/datasets/dummy_dataset.py Outdated Show resolved Hide resolved
@otaj otaj mentioned this pull request Aug 15, 2022
Open
@mergify mergify bot added the ready label Aug 15, 2022
@otaj otaj merged commit 86f5d09 into Lightning-Universe:master Aug 16, 2022
@nishantb06 nishantb06 deleted the dummy_datasets branch August 16, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otaj otaj otaj approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@akihironitta akihironitta Awaiting requested review from akihironitta

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli awaelchli is a code owner

Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nishantb06 @otaj