Feature - ArrayDataset

[Ce11an]

What does this PR do?

Part of #839

• pl_bolts.datamodules.sklearn_datamodule.TensorDataset

Summary

• Replaced TensorDataset with ArrayDataset. (breaking change ❗ )
• Moved ArrayDataset to datasets module.

The ArrayDataset allows you to input any number of ARRAYS along with callable transforms using the DataModel. The ArrayDataset allows for the following types:

• Lists / Nested Lists
• Numpy Arrays
• Torch Tensors

This eliminates the need for the TensorDataset.

Transforms are called during each __getitem__. @otaj and I have discussed the potential inefficiencies of this. However, we have decided to stay consistent with the rest of bolts and vision. Happily open to having that discussion again, though!

Also, after discussing with @otaj, we thought it would be best to separate #846.

Before submitting

• Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes?
• Did you write any new necessary tests? [not needed for typos/docs]
• Did you verify new and existing tests pass locally with your changes?
• If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

• Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Of course 🥳

[Ce11an]

Hey 👋🏻

Sorry, I think someone needs to approve the workflows again. I have resolved @otaj's comments. Thanks 😃

[Ce11an]

Thanks, @otaj!

mypy does not support recursive types. Currently, there is an experimental feature: python/mypy#731

What would you recommend?

[otaj]

Thanks, @otaj!

mypy does not support recursive types. Currently, there is an experimental feature: python/mypy#731

What would you recommend?

Yeah, I sadly know about it, mypy can sometimes be a bit of a pain. I don't know if mypy has problem only with definition line or with all the lines where the recursive type is being used. If it's the latter, then we probably need to abandon recursive type, since it doesn't make sense to ignore everything. But, if it's only the former case, then I'm perfectly fine with just type: ignore on that line

[Ce11an]

There were two issues. I have had to add float type and ignore TArrays in mypy.

Are you happy to use float to represent int? Pep 484