Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics #878

Merged
merged 20 commits into from Sep 19, 2022
Merged

Metrics #878

merged 20 commits into from Sep 19, 2022

Conversation

BaruchG
Copy link
Contributor

@BaruchG BaruchG commented Sep 9, 2022

What does this PR do?

Part of Issue #839 and updates pl_bolts.metrics.aggregation.* with tests for all functions.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@otaj
Copy link
Contributor

otaj commented Sep 16, 2022

Hi, @BaruchG, should I review the PR (or do you need some help with it)? Or is the draft status correct? ⚡

@otaj otaj mentioned this pull request Sep 16, 2022
@BaruchG
Copy link
Contributor Author

BaruchG commented Sep 16, 2022

Hey @otaj - I was confused by what's happening with the failing tests. I've reached out over slack to discuss further. Thanks!

@BaruchG
Copy link
Contributor Author

BaruchG commented Sep 16, 2022

Ok, got this fixed. Should be ready for review.

@BaruchG BaruchG marked this pull request as ready for review September 16, 2022 21:49
@Borda Borda added the enhancement New feature or request label Sep 19, 2022
@Borda Borda merged commit 8fb0869 into Lightning-Universe:master Sep 19, 2022
@mergify mergify bot added the ready label Sep 19, 2022
@BaruchG BaruchG deleted the metrics branch September 19, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants