Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision of SimSiam module and tests #891

Merged
merged 13 commits into from Oct 11, 2022

Conversation

matsumotosan
Copy link
Contributor

@matsumotosan matsumotosan commented Sep 24, 2022

What does this PR do?

Fixes part of #839

Summary

  • Remove parts unrelated to model from SimSiam
  • Set default model parameters to those from the original paper
  • Test revised module

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • N/A If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the model label Sep 24, 2022
@otaj otaj mentioned this pull request Sep 28, 2022
@matsumotosan matsumotosan marked this pull request as ready for review October 10, 2022 00:13
@matsumotosan matsumotosan marked this pull request as draft October 10, 2022 10:42
@matsumotosan matsumotosan marked this pull request as ready for review October 11, 2022 01:36
Copy link
Contributor

@otaj otaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I've already reviewed this 😄 It looks good, to be fair, thank you 🔩

@otaj otaj merged commit a8bbfc9 into Lightning-Universe:master Oct 11, 2022
@mergify mergify bot added the ready label Oct 11, 2022
@matsumotosan matsumotosan deleted the simsiam_module branch October 11, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants