Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

fix type of 'n_gram' from bool to int in TranslationTask #1486

Merged

Conversation

BrightXiaoHan
Copy link
Contributor

What does this PR do?

fix type of 'n_gram' from bool to int in TranslationTask

Fixes #1485

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 92.34% // Head: 83.24% // Decreases project coverage by -9.10% ⚠️

Coverage data is based on head (a0e21a8) compared to base (0e1a9fe).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1486      +/-   ##
==========================================
- Coverage   92.34%   83.24%   -9.11%     
==========================================
  Files         292      292              
  Lines       13158    13158              
==========================================
- Hits        12151    10953    -1198     
- Misses       1007     2205    +1198     
Flag Coverage Δ
pytest 13.03% <ø> (ø)
tpu 13.03% <ø> (ø)
unittests 83.72% <ø> (-9.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/text/seq2seq/translation/model.py 95.45% <ø> (ø)
...lash/image/embedding/vissl/transforms/utilities.py 15.15% <0.00%> (-84.85%) ⬇️
flash/core/integrations/labelstudio/visualizer.py 24.00% <0.00%> (-72.00%) ⬇️
flash/image/embedding/heads/vissl_heads.py 35.29% <0.00%> (-64.71%) ⬇️
.../image/classification/integrations/baal/dropout.py 28.00% <0.00%> (-64.00%) ⬇️
flash/image/embedding/losses/vissl_losses.py 37.50% <0.00%> (-62.50%) ⬇️
flash/image/embedding/vissl/adapter.py 31.63% <0.00%> (-62.25%) ⬇️
flash/image/detection/input.py 38.88% <0.00%> (-61.12%) ⬇️
...ash/image/classification/integrations/baal/loop.py 33.82% <0.00%> (-59.56%) ⬇️
...age/face_detection/backbones/fastface_backbones.py 42.10% <0.00%> (-57.90%) ⬇️
... and 63 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 😃

@Borda Borda merged commit 041c8e0 into Lightning-Universe:master Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The type of n_gram is mislabeled as bool, which should be int type.
3 participants