Skip to content
This repository has been archived by the owner on Nov 21, 2022. It is now read-only.

Feat/remove configs #264

Merged
merged 10 commits into from
Jun 23, 2022
Merged

Feat/remove configs #264

merged 10 commits into from
Jun 23, 2022

Conversation

SeanNaren
Copy link
Contributor

Closes #246

@SeanNaren SeanNaren requested a review from Borda as a code owner June 23, 2022 09:31
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #264 (934a483) into master (9026a1e) will decrease coverage by 2%.
The diff coverage is 88%.

@@          Coverage Diff          @@
##           master   #264   +/-   ##
=====================================
- Coverage      75%    74%   -2%     
=====================================
  Files          73     62   -11     
  Lines        1557   1460   -97     
=====================================
- Hits         1170   1075   -95     
+ Misses        387    385    -2     

@SeanNaren SeanNaren merged commit e51ce01 into master Jun 23, 2022
@SeanNaren SeanNaren deleted the feat/remove_configs branch June 23, 2022 11:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move away from configs, to just passing args to the class
1 participant