Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix srun detection causing permission error on non-SLURM platforms #15485

Merged
merged 4 commits into from Nov 3, 2022
Merged

Fix srun detection causing permission error on non-SLURM platforms #15485

merged 4 commits into from Nov 3, 2022

Conversation

awaelchli
Copy link
Member

@awaelchli awaelchli commented Nov 2, 2022 •
edited by github-actions bot

What does this PR do?

Fixes #15455

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @tchaton @rohitgr7 @awaelchli

@awaelchli awaelchli added bug Something isn't working environment: slurm labels Nov 2, 2022
@awaelchli awaelchli added this to the v1.8.x milestone Nov 2, 2022
@awaelchli awaelchli self-assigned this Nov 2, 2022
@awaelchli awaelchli marked this pull request as ready for review November 2, 2022 22:59
@awaelchli awaelchli added the community This PR is from the community label Nov 2, 2022
@awaelchli awaelchli mentioned this pull request Nov 2, 2022
Closed
@awaelchli awaelchli added the priority: 0 High priority task label Nov 2, 2022
@mergify mergify bot added the ready PRs ready to be merged label Nov 3, 2022
@Borda Borda merged commit 9c20cad into master Nov 3, 2022
@Borda Borda deleted the bugfix/srun-detection branch November 3, 2022 02:14
Borda pushed a commit that referenced this pull request Nov 5, 2022
@awaelchli @Borda
Fix srun detection causing permission error on non-SLURM platforms (#…
4ac57b4 
…15485)

* improve srun detection
* changelog
* try catch is obsolete

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 9c20cad)
speediedan added a commit to speediedan/finetuning-scheduler that referenced this pull request Nov 8, 2022
@speediedan
remove PATH adjustments that are no longer necessary due to Lightning…
8618e8b 
…-AI/pytorch-lightning#15485
lexierule pushed a commit that referenced this pull request Nov 10, 2022
@awaelchli @lexierule
Fix srun detection causing permission error on non-SLURM platforms (#…
ee464ef 
…15485)

* improve srun detection
* changelog
* try catch is obsolete

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 9c20cad)
speediedan added a commit to speediedan/finetuning-scheduler that referenced this pull request Nov 10, 2022
@speediedan
remove PATH adjustments that are no longer necessary due to Lightning…
5c67a8f 
…-AI/pytorch-lightning#15485
speediedan added a commit to speediedan/finetuning-scheduler that referenced this pull request Nov 10, 2022
@speediedan
Revert "remove PATH adjustments that are no longer necessary due to L…
7fa312f 
…ightning-AI/pytorch-lightning#15485"

This reverts commit 5c67a8f.
@awaelchli awaelchli added fun Staff contributions outside working hours - to differentiate from the "community" label and removed community This PR is from the community labels Nov 21, 2022
@nicolai86 nicolai86 mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@carmocca carmocca carmocca approved these changes

@justusschock justusschock Awaiting requested review from justusschock

Assignees

@awaelchli awaelchli

Labels
bug Something isn't working environment: slurm fun Staff contributions outside working hours - to differentiate from the "community" label priority: 0 High priority task ready PRs ready to be merged
Projects
No open projects
Frameworks Planning
Status: Done
Milestone
v1.8.x
Development

Successfully merging this pull request may close these issues.

Permission Error when creating a trainer
3 participants
@awaelchli @Borda @carmocca