Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate optimizer step logic to the PrecisionPlugin #10029

Merged
merged 9 commits into from Oct 20, 2021

Conversation

carmocca
Copy link
Member

@carmocca carmocca commented Oct 19, 2021

What does this PR do?

  • Run the closure to PrecisionPlugin.pre_optimizer_step whenever possible. This will make the transition to only allowing the step in the PrecisionPlugin easier.
  • Improve unsupported LBFGS checks
  • Improve unsupported backward skipping checks.

Part of #9287

Does your PR introduce any breaking changes? If yes, please list them.

None in stable API

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added this to the v1.5 milestone Oct 19, 2021
@carmocca carmocca self-assigned this Oct 19, 2021
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #10029 (265189e) into master (2ed92ec) will decrease coverage by 0%.
The diff coverage is 60%.

@@           Coverage Diff           @@
##           master   #10029   +/-   ##
=======================================
- Coverage      93%      93%   -0%     
=======================================
  Files         180      180           
  Lines       15892    15909   +17     
=======================================
+ Hits        14722    14725    +3     
- Misses       1170     1184   +14     

@mergify mergify bot added the ready PRs ready to be merged label Oct 20, 2021
@carmocca carmocca enabled auto-merge (squash) October 20, 2021 14:42
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca merged commit ef5a122 into master Oct 20, 2021
@carmocca carmocca deleted the refactor/constain-step-logic branch October 20, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants