Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary _move_optimizer_state method overrides #10849

Merged
merged 10 commits into from Dec 2, 2021

Conversation

four4fish
Copy link
Contributor

@four4fish four4fish commented Nov 30, 2021

What does this PR do?

Fixes #10820

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

@four4fish four4fish marked this pull request as draft November 30, 2021 18:23
@four4fish four4fish changed the title Update tpu tp share same logic with ttp Update tpu _move_optimizer_state to share same logic with ttp Nov 30, 2021
@four4fish four4fish changed the title Update tpu _move_optimizer_state to share same logic with ttp Update tpu _move_optimizer_state() to share same logic with ttp Nov 30, 2021
@four4fish four4fish marked this pull request as ready for review December 1, 2021 19:58
@awaelchli awaelchli added this to the 1.6 milestone Dec 1, 2021
@four4fish four4fish changed the title Update tpu _move_optimizer_state() to share same logic with ttp Removed unnecessary _move_optimizer_state method overrides Dec 1, 2021
Co-authored-by: Adrian W盲lchli <aedu.waelchli@gmail.com>
@mergify mergify bot added the ready PRs ready to be merged label Dec 1, 2021
@mergify mergify bot added the has conflicts label Dec 2, 2021
@mergify mergify bot removed the has conflicts label Dec 2, 2021
@four4fish four4fish enabled auto-merge (squash) December 2, 2021 04:33
@four4fish four4fish merged commit 9beeabb into Lightning-AI:master Dec 2, 2021
@awaelchli awaelchli added strategy: ddp DistributedDataParallel and removed strategy: ddp spawn labels Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: tpu Tensor Processing Unit ready PRs ready to be merged refactor strategy: ddp DistributedDataParallel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit _move_optimizer_state function for all Strategies
4 participants