New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed unnecessary _move_optimizer_state
method overrides
#10849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
four4fish
requested review from
awaelchli,
justusschock,
SeanNaren and
tchaton
as code owners
November 30, 2021 18:23
four4fish
changed the title
Update tpu tp share same logic with ttp
Update tpu _move_optimizer_state to share same logic with ttp
Nov 30, 2021
four4fish
changed the title
Update tpu _move_optimizer_state to share same logic with ttp
Update tpu _move_optimizer_state() to share same logic with ttp
Nov 30, 2021
four4fish
commented
Dec 1, 2021
four4fish
requested review from
Borda,
carmocca,
kaushikb11,
rohitgr7 and
williamFalcon
as code owners
December 1, 2021 19:58
awaelchli
added
accelerator: tpu
Tensor Processing Unit
refactor
strategy: ddp spawn
labels
Dec 1, 2021
four4fish
changed the title
Update tpu _move_optimizer_state() to share same logic with ttp
Removed unnecessary Dec 1, 2021
_move_optimizer_state
method overrides
awaelchli
approved these changes
Dec 1, 2021
pytorch_lightning/plugins/training_type/training_type_plugin.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Adrian W盲lchli <aedu.waelchli@gmail.com>
ananthsub
approved these changes
Dec 1, 2021
carmocca
approved these changes
Dec 2, 2021
awaelchli
added
strategy: ddp
DistributedDataParallel
and removed
strategy: ddp spawn
labels
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accelerator: tpu
Tensor Processing Unit
ready
PRs ready to be merged
refactor
strategy: ddp
DistributedDataParallel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #10820
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 馃檭