Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LR scheduler getting called excessively with amp #11542

Closed
wants to merge 2 commits into from

Conversation

akihironitta
Copy link
Contributor

WIP

What does this PR do?

Fixes #5558
Redo #9923

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

@stale
Copy link

stale bot commented Feb 5, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Feb 5, 2022
@awaelchli awaelchli added the bug Something isn't working label Feb 5, 2022
@stale stale bot removed the won't fix This will not be worked on label Feb 5, 2022
@awaelchli awaelchli added precision: amp Automatic Mixed Precision won't fix This will not be worked on labels Feb 5, 2022
@stale stale bot removed the won't fix This will not be worked on label Feb 5, 2022
@stale
Copy link

stale bot commented Feb 24, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Feb 24, 2022
@akihironitta akihironitta removed the won't fix This will not be worked on label Feb 25, 2022
@akihironitta
Copy link
Contributor Author

Will continue this after #11755.

@akihironitta akihironitta added this to the 1.6 milestone Mar 11, 2022
@akihironitta akihironitta self-assigned this Mar 11, 2022
@akihironitta akihironitta modified the milestones: 1.6, 1.6.x Mar 28, 2022
@carmocca carmocca removed this from the pl:1.6.x milestone Jul 28, 2022
@carmocca
Copy link
Contributor

carmocca commented Nov 8, 2022

@akihironitta Should we close this? It's not a big priority to fix it. Also the fix should probably be done in PyTorch

@akihironitta
Copy link
Contributor Author

Yes, let's. For anyone seeing this PR, please refer to the workaround in #5558 (comment).

@akihironitta akihironitta deleted the bugfix/amp-scheduler branch November 8, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working precision: amp Automatic Mixed Precision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mixed precision: scheduler and optimizer are called in the wrong order
3 participants