Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further clean up aggregation logic #12053

Merged
merged 5 commits into from Feb 23, 2022

Conversation

daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Feb 22, 2022

What does this PR do?

After I showed in #9145 (comment) that the aggregation logic in LightningLoggerBase is a no-op, due to the should_accumulate check in the fit loop, we can further clean up this code here without affecting anything.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@daniellepintz daniellepintz marked this pull request as ready for review February 23, 2022 02:25
@mergify mergify bot added the ready PRs ready to be merged label Feb 23, 2022
@daniellepintz daniellepintz added this to the 1.6 milestone Feb 23, 2022
@rohitgr7 rohitgr7 added the logger Related to the Loggers label Feb 23, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) February 23, 2022 14:36
@daniellepintz
Copy link
Contributor Author

Could someone rerun the TPU tests which failed?

@rohitgr7 rohitgr7 merged commit a8ee5ca into Lightning-AI:master Feb 23, 2022
@daniellepintz daniellepintz deleted the clean_up_agg branch February 23, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logger Related to the Loggers ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants