Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate LoggerCollection in favor of trainer.loggers #12147

Merged
merged 12 commits into from Mar 4, 2022
Merged

Deprecate LoggerCollection in favor of trainer.loggers #12147

merged 12 commits into from Mar 4, 2022

Conversation

akashkw
Copy link
Contributor

@akashkw akashkw commented Feb 28, 2022 •
edited

What does this PR do?

Fixes #11232

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

@akashkw akashkw marked this pull request as ready for review February 28, 2022 21:44
@akashkw akashkw changed the title Deprecate LoggerCollection Deprecate LoggerCollection in favor of trainer.loggers Feb 28, 2022
carmocca
carmocca reviewed Feb 28, 2022
View reviewed changes
tests/trainer/properties/test_loggers.py Outdated Show resolved Hide resolved
pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
@ananthsub ananthsub added deprecation Includes a deprecation logger Related to the Loggers labels Mar 1, 2022
ananthsub
ananthsub approved these changes Mar 1, 2022
View reviewed changes
pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Mar 1, 2022
@daniellepintz daniellepintz added this to the 1.6 milestone Mar 1, 2022
@ananthsub ananthsub enabled auto-merge (squash) March 2, 2022 02:19
auto-merge was automatically disabled March 2, 2022 18:26

Head branch was pushed to by a user without write access

@ananthsub ananthsub enabled auto-merge (squash) March 2, 2022 18:45
awaelchli
awaelchli approved these changes Mar 2, 2022
View reviewed changes
pytorch_lightning/loggers/base.py Outdated Show resolved Hide resolved
pytorch_lightning/loggers/base.py Outdated Show resolved Hide resolved
tests/trainer/properties/test_loggers.py Show resolved Hide resolved
auto-merge was automatically disabled March 2, 2022 23:31

Head branch was pushed to by a user without write access

@awaelchli awaelchli enabled auto-merge (squash) March 2, 2022 23:57
@awaelchli awaelchli disabled auto-merge March 4, 2022 21:21
@awaelchli awaelchli enabled auto-merge (squash) March 4, 2022 21:21
@awaelchli awaelchli merged commit 1f7298d into Lightning-AI:master Mar 4, 2022
@akashkw akashkw deleted the deprecate/logger-collection branch March 4, 2022 23:02
@Borda Borda mentioned this pull request Mar 9, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananthsub ananthsub ananthsub approved these changes

@awaelchli awaelchli awaelchli approved these changes

@daniellepintz daniellepintz daniellepintz left review comments

@carmocca carmocca carmocca approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@justusschock justusschock Awaiting requested review from justusschock

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@edward-io edward-io Awaiting requested review from edward-io

Assignees
No one assigned
Labels
deprecation Includes a deprecation logger Related to the Loggers ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

[RFC] Better support using multiple loggers simultaneously by deprecating LoggerCollection
6 participants
@akashkw @ananthsub @awaelchli @carmocca @rohitgr7 @daniellepintz