Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated get_progress_bar_dict #12839

Merged
merged 20 commits into from
Apr 22, 2022
Merged

Remove the deprecated get_progress_bar_dict #12839

merged 20 commits into from
Apr 22, 2022

Conversation

rschireman
Copy link
Contributor

@rschireman rschireman commented Apr 21, 2022

What does this PR do?

Fixes part of #12521 by removing the deprecated LightningModule.get_progress_bar_dict

Does your PR introduce any breaking changes? If yes, please list them.

yes, completely removes LightningModule.get_progress_bar_dict

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca carmocca added breaking change Includes a breaking change hooks Related to the hooks API community This PR is from the community labels Apr 22, 2022
@carmocca carmocca added this to the 1.7 milestone Apr 22, 2022
@carmocca carmocca self-assigned this Apr 22, 2022
@carmocca carmocca enabled auto-merge (squash) April 22, 2022 14:31
@mergify mergify bot added the ready PRs ready to be merged label Apr 22, 2022
@carmocca carmocca merged commit f931e27 into Lightning-AI:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change community This PR is from the community hooks Related to the hooks API ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants