Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TQDMProgressBar reset and update to show correct time estimation #12889

Merged
merged 8 commits into from May 3, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Apr 26, 2022

What does this PR do?

Fixes #12875
Also fixes #12787

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

cc @Borda @tchaton @rohitgr7 @awaelchli

@rohitgr7 rohitgr7 added bug Something isn't working priority: 0 High priority task progress bar: tqdm labels Apr 26, 2022
@rohitgr7 rohitgr7 added this to the 1.6.x milestone Apr 26, 2022
@rohitgr7
Copy link
Contributor Author

I am unsure how to test this since all I could do is observe the tqdm bar and check the it/s consistency across epochs.

CHANGELOG.md Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 changed the title Fix tqdm total and update Fix TQDMProgressBar reset and update to show correct time estimation May 3, 2022
@rohitgr7 rohitgr7 requested a review from carmocca May 3, 2022 12:57
@mergify mergify bot added the ready PRs ready to be merged label May 3, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) May 3, 2022 15:35
@rohitgr7 rohitgr7 merged commit 5dc8951 into master May 3, 2022
@rohitgr7 rohitgr7 deleted the fix/tqdm_init branch May 3, 2022 16:22
carmocca added a commit that referenced this pull request May 3, 2022
#12889)

Co-authored-by: Carlos Mochol铆 <carlossmocholi@gmail.com>
carmocca added a commit that referenced this pull request May 3, 2022
#12889)

Co-authored-by: Carlos Mochol铆 <carlossmocholi@gmail.com>
lexierule pushed a commit that referenced this pull request May 3, 2022
#12889)

Co-authored-by: Carlos Mochol铆 <carlossmocholi@gmail.com>
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
12 tasks
@awaelchli awaelchli mentioned this pull request Aug 1, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: 0 High priority task progress bar: tqdm ready PRs ready to be merged
Projects
None yet
4 participants