New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TQDMProgressBar
reset and update to show correct time estimation
#12889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitgr7
added
bug
Something isn't working
priority: 0
High priority task
progress bar: tqdm
labels
Apr 26, 2022
I am unsure how to test this since all I could do is observe the tqdm bar and check the it/s consistency across epochs. |
This was referenced Apr 26, 2022
rohitgr7
requested review from
williamFalcon,
tchaton,
carmocca,
Borda,
kaushikb11,
SeanNaren,
awaelchli and
justusschock
as code owners
May 2, 2022 18:33
rohitgr7
commented
May 3, 2022
rohitgr7
commented
May 3, 2022
rohitgr7
changed the title
Fix tqdm total and update
Fix May 3, 2022
TQDMProgressBar
reset and update to show correct time estimation
Borda
approved these changes
May 3, 2022
carmocca
reviewed
May 3, 2022
carmocca
reviewed
May 3, 2022
carmocca
approved these changes
May 3, 2022
otaj
approved these changes
May 3, 2022
carmocca
approved these changes
May 3, 2022
carmocca
added a commit
that referenced
this pull request
May 3, 2022
#12889) Co-authored-by: Carlos Mochol铆 <carlossmocholi@gmail.com>
carmocca
added a commit
that referenced
this pull request
May 3, 2022
#12889) Co-authored-by: Carlos Mochol铆 <carlossmocholi@gmail.com>
lexierule
pushed a commit
that referenced
this pull request
May 3, 2022
#12889) Co-authored-by: Carlos Mochol铆 <carlossmocholi@gmail.com>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
priority: 0
High priority task
progress bar: tqdm
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12875
Also fixes #12787
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 馃檭
cc @Borda @tchaton @rohitgr7 @awaelchli