Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in upload file endpoint #14924

Merged
merged 13 commits into from Oct 5, 2022
Merged

Fix bug in upload file endpoint #14924

merged 13 commits into from Oct 5, 2022

Conversation

ethanwharris
Copy link
Member

@ethanwharris ethanwharris commented Sep 28, 2022

What does this PR do?

Test fails on master

Fixes #14923 - wrap the drive.put in a work context

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

cc @Borda

@github-actions github-actions bot added the app Generic label for Lightning App package label Sep 28, 2022
@ethanwharris ethanwharris changed the title [WIP] Fix bug in upload file endpoint Fix bug in upload file endpoint Sep 28, 2022
@ethanwharris ethanwharris marked this pull request as ready for review September 28, 2022 19:21
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Sep 28, 2022
@ethanwharris ethanwharris added this to the app:0.6.x milestone Sep 29, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Oct 4, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Oct 4, 2022
@mergify mergify bot added the ready PRs ready to be merged label Oct 4, 2022
@tchaton tchaton enabled auto-merge (squash) October 5, 2022 07:35
@tchaton tchaton merged commit 0a9fc22 into master Oct 5, 2022
@tchaton tchaton deleted the bugfix/upload_files_context branch October 5, 2022 10:05
nicolai86 pushed a commit that referenced this pull request Oct 13, 2022
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: otaj <6065855+otaj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Generic label for Lightning App package ready PRs ready to be merged
Projects
None yet
6 participants