Allow force run app on cloud if loading locally errors

[manskx]

What does this PR do?

User story:
As a user, I want to be able to run lightning apps on the cloud and I don't need to install the dependencies locally.

If the app() cannot be loaded locally, it shows the following (the message needs to be revisited to tell the user it's better to save debugging time torun the app locally before running on cloud):

"Could not load the app() locally. Starting the app directly on the cloud."

Limitations:

• features like defining the flow cloudconfig might not be supported/
• DO NOT MERGE until the lightning backend supports dynamic flow server loading

TODO:

Add e2e test for this feature or add it to one of the apps.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

• Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes? (if necessary)
• Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• Did you list all the breaking changes introduced by this pull request?
• Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

[nicolai86]

isn't

features like defining the flow cloudconfig might not be supported/

a blocker for co-locating work and flow on the same nodes?

[manskx]

isn't

features like defining the flow cloudconfig might not be supported/

a blocker for co-locating work and flow on the same nodes?

It depends on how it is implemented, if it requires the load of the app() before running on the cloud then yes it won't be compatible with this PR. I believe that ideally we should try to avoid loading app() as much as we can.

[manskx]

This message could be improved.
Could not load the app() locally. Starting the app directly on the cloud.

we want to inform the user that it's better to make sure the app runs locally first before running on cloud because it might contain errors.

@edenafek what do you think ?

[tchaton]

Approving for now, but we would need a smarter mechanism to better collect the specs.

[lantiga]

LGTM, a tiny nit