Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use monkeypatch.chdir instead of os.chdir in tests #15579

Merged
merged 6 commits into from
Nov 10, 2022
Merged

Use monkeypatch.chdir instead of os.chdir in tests #15579

merged 6 commits into from
Nov 10, 2022

Conversation

tanaymeh
Copy link
Contributor

@tanaymeh tanaymeh commented Nov 8, 2022 •
edited by awaelchli

What does this PR do?

This PR changes os.chdir() calls to monkeypatch.chdir() in test as requested in issue #15576

Fixes #15576

Does your PR introduce any breaking changes? If yes, please list them.

No

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

@Borda @awaelchli

Did you have fun?

Yes!

@github-actions github-actions bot added the app Generic label for Lightning App package label Nov 8, 2022
@awaelchli awaelchli self-assigned this Nov 10, 2022
@awaelchli awaelchli added tests code quality community This PR is from the community labels Nov 10, 2022
@awaelchli awaelchli added this to the v1.8.x milestone Nov 10, 2022
@awaelchli awaelchli marked this pull request as ready for review November 10, 2022 10:08
tchaton
tchaton approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ! Thanks.

@tchaton tchaton merged commit 680408e into Lightning-AI:master Nov 10, 2022
@mergify mergify bot added the ready PRs ready to be merged label Nov 10, 2022
@tanaymeh tanaymeh deleted the refactor/15576_use_monkeypatch branch November 10, 2022 12:12
Borda pushed a commit that referenced this pull request Nov 10, 2022
@tanaymeh @Borda
Use monkeypatch.chdir instead of os.chdir in tests (#15579)
420014f 
(cherry picked from commit 680408e)
lexierule pushed a commit that referenced this pull request Nov 10, 2022
@tanaymeh @lexierule
Use monkeypatch.chdir instead of os.chdir in tests (#15579)
cd1f8f3 
(cherry picked from commit 680408e)
@nicolai86 nicolai86 mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton tchaton approved these changes

@hhsecond hhsecond Awaiting requested review from hhsecond

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@Borda Borda Awaiting requested review from Borda Borda is a code owner

Assignees

@awaelchli awaelchli

Labels
app Generic label for Lightning App package code quality community This PR is from the community ready PRs ready to be merged tests
Projects
None yet
Milestone
v1.8.x
Development

Successfully merging this pull request may close these issues.

Use monkeypatch.chdir instead of os.chdir in tests
3 participants
@tanaymeh @awaelchli @tchaton