Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reinforcement learning example for Fabric #16506

Merged
merged 16 commits into from Jan 27, 2023

Conversation

belerico
Copy link
Contributor

@belerico belerico commented Jan 25, 2023

What does this PR do?

This PR introduces a first example of Reinforcement Learning training accelerated by Fabric. In particular, the Proximal Policy Optimization (PPO) algorithm is implemented. As for the other examples, two scripts are given: one that runs the optimization with raw PyTorch, while the other one employing Fabric.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Jan 25, 2023
@awaelchli awaelchli added example community This PR is from the community labels Jan 26, 2023
Copy link
Member

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. Thank you for contributing this example @belerico

examples/fabric/reinforcement_learning/train_torch.py Outdated Show resolved Hide resolved
examples/fabric/reinforcement_learning/train_fabric.py Outdated Show resolved Hide resolved
examples/fabric/reinforcement_learning/train_torch.py Outdated Show resolved Hide resolved
@awaelchli awaelchli added this to the 2.0 milestone Jan 26, 2023
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jan 26, 2023
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, small tweak to the intro

examples/fabric/reinforcement_learning/README.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Jan 27, 2023
Co-authored-by: Luca Antiga <luca@lightning.ai>
@awaelchli awaelchli enabled auto-merge (squash) January 27, 2023 11:25
@awaelchli awaelchli merged commit b5599e1 into Lightning-AI:master Jan 27, 2023
@lantiga
Copy link
Collaborator

lantiga commented Jan 27, 2023

Great job @belerico !

@belerico
Copy link
Contributor Author

Thank you all!

@Borda
Copy link
Member

Borda commented Jan 27, 2023

Sweet, nice first contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community example fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants