[App] Add rm one level below project level #16740

tchaton · 2023-02-13T10:41:59Z

What does this PR do?

This PR enables to delete files from the Lightning AI Cloud Filesystem.

lightning rm my_file.txt

Fixes #<issue_number>

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda

github-actions · 2023-02-13T10:53:01Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, lightning, 3.8, latest)	success	✅
app-pytest (macOS-11, lightning, 3.8, oldest)	success	✅
app-pytest (macOS-11, app, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, app, 3.9, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, oldest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅

These checks are required after the changes to src/lightning/app/cli/commands/cp.py, src/lightning/app/cli/commands/ls.py, src/lightning/app/cli/commands/rm.py, src/lightning/app/cli/lightning_cli.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/cli_helpers.py, tests/tests_app/cli/test_rm.py, tests/tests_app/utilities/test_commands.py.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (macOS-11, lightning, 3.9, oldest)	success	✅
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, oldest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅

These checks are required after the changes to src/lightning/app/cli/commands/cp.py, src/lightning/app/cli/commands/ls.py, src/lightning/app/cli/commands/rm.py, src/lightning/app/cli/lightning_cli.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/cli_helpers.py, tests/integrations_app/public/test_commands_and_api.py, examples/app_commands_and_api/app.py.

🟢 lightning_app: Azure

Check ID	Status
App.cloud-e2e	success	✅

These checks are required after the changes to src/lightning/app/cli/commands/cp.py, src/lightning/app/cli/commands/ls.py, src/lightning/app/cli/commands/rm.py, src/lightning/app/cli/lightning_cli.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/cli_helpers.py, tests/integrations_app/public/test_commands_and_api.py.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (lightning)	success	✅
make-html (lightning)	success	✅

These checks are required after the changes to src/lightning/app/cli/commands/cp.py, src/lightning/app/cli/commands/ls.py, src/lightning/app/cli/commands/rm.py, src/lightning/app/cli/lightning_cli.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/cli_helpers.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning/app/cli/commands/cp.py, src/lightning/app/cli/commands/ls.py, src/lightning/app/cli/commands/rm.py, src/lightning/app/cli/lightning_cli.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/cli_helpers.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning/app/cli/commands/cp.py, src/lightning/app/cli/commands/ls.py, src/lightning/app/cli/commands/rm.py, src/lightning/app/cli/lightning_cli.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/cli_helpers.py.

🟢 link-check

Check ID	Status
markdown-link-check	success	✅

These checks are required after the changes to src/lightning/app/CHANGELOG.md.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

…to add_rm

src/lightning/app/cli/commands/rm.py

Co-authored-by: Ethan Harris <ethanwharris@gmail.com>

…to add_rm

src/lightning/app/cli/commands/rm.py

Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>

Co-authored-by: Ethan Harris <ethanwharris@gmail.com> Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com> Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local>

* Add .git-blame-ignore-revs (#16709) Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> * Fix strategy type validation in connectors (#16693) * Disable strict loading in multiprocessing launcher (#16365) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka <jirka.borovec@seznam.cz> * Fix min-epochs and early-stopping triggering too many validation runs (#16719) Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> * Update hydra-core requirement from <1.3.0,>=1.0.5 to >=1.0.5,<1.4.0 in /requirements (#16736) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [App] Add support for private data (#16738) Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local> * [App] Add rm one level below project level (#16740) Co-authored-by: Ethan Harris <ethanwharris@gmail.com> Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com> Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local> * ci: cleaning caches (#16752) * CI: Update colossalai version (#16747) Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> type * Update version and changelog for 1.9.2 --------- Co-authored-by: Akihiro Nitta <nitta@akihironitta.com> Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka <jirka.borovec@seznam.cz> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: thomas chaton <thomas@grid.ai> Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local> Co-authored-by: Ethan Harris <ethanwharris@gmail.com> Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>

thomas added 2 commits February 13, 2023 10:40

update

a29d830

update

cb103d4

github-actions bot added the app Generic label for Lightning App package label Feb 13, 2023

thomas and others added 2 commits February 13, 2023 10:51

update

e3c2047

Merge branch 'master' into add_rm

223466b

tchaton marked this pull request as ready for review February 13, 2023 10:52

tchaton requested review from lantiga, awaelchli, hhsecond and ethanwharris as code owners February 13, 2023 10:52

tchaton self-assigned this Feb 13, 2023

tchaton added the feature Is an improvement or enhancement label Feb 13, 2023

tchaton added this to the future milestone Feb 13, 2023

thomas and others added 10 commits February 13, 2023 18:44

update

7b6e083

Merge branch 'add_rm' of https://github.com/Lightning-AI/lightning in…

f2733e8

…to add_rm

Merge branch 'master' into add_rm

5e913ed

update

9246415

Merge branch 'add_rm' of https://github.com/Lightning-AI/lightning in…

ad2b363

…to add_rm

update

9283350

Merge branch 'master' into add_rm

1699155

update

20f674a

update

8e12aea

Merge branch 'add_rm' of https://github.com/Lightning-AI/lightning in…

54f0acd

…to add_rm

ethanwharris approved these changes Feb 14, 2023

View reviewed changes

src/lightning/app/cli/commands/rm.py Outdated Show resolved Hide resolved

src/lightning/app/cli/commands/rm.py Show resolved Hide resolved

Update src/lightning/app/cli/commands/rm.py

5508e20

Co-authored-by: Ethan Harris <ethanwharris@gmail.com>

tchaton changed the title ~~[App] Add rm at the project level~~ [App] Add rm one level below project level Feb 14, 2023

thomas added 3 commits February 14, 2023 11:16

update

d47e327

Merge branch 'add_rm' of https://github.com/Lightning-AI/lightning in…

8fe6450

…to add_rm

update

d848de1

Merge branch 'master' into add_rm

d0b73cd

justusschock approved these changes Feb 14, 2023

View reviewed changes

src/lightning/app/cli/commands/rm.py Outdated Show resolved Hide resolved

mergify bot added the ready PRs ready to be merged label Feb 14, 2023

Update src/lightning/app/cli/commands/rm.py

b87def0

Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>

tchaton enabled auto-merge (squash) February 14, 2023 11:27

Merge branch 'master' into add_rm

98f3c01

mergify bot added has conflicts and removed ready PRs ready to be merged labels Feb 14, 2023

Merge branch 'master' into add_rm

3e27f76

mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Feb 14, 2023

tchaton merged commit 104290e into master Feb 14, 2023

tchaton deleted the add_rm branch February 14, 2023 14:12

carmocca modified the milestones: future, v1.9.x Feb 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[App] Add rm one level below project level #16740

[App] Add rm one level below project level #16740

tchaton commented Feb 13, 2023 •

edited by github-actions bot

github-actions bot commented Feb 13, 2023 •

edited

[App] Add rm one level below project level #16740

[App] Add rm one level below project level #16740

Conversation

tchaton commented Feb 13, 2023 • edited by github-actions bot

What does this PR do?

PR review

github-actions bot commented Feb 13, 2023 • edited

⚡ Required checks status: All passing 🟢

Groups summary

tchaton commented Feb 13, 2023 •

edited by github-actions bot

github-actions bot commented Feb 13, 2023 •

edited